Theme Settings

This component gives possibility to construct custom blocks with any widgets, components and elements inside, like this theme settings

Menu Type
Toggled left menu
Unfixed left menu
Fixed topbar
Menu color
Flyout menu
Login color
Content no max-width
App max-width
Gray background
Gray topbar
Squared card borders
Card shadow
Borderless cards
Menu shadow
Support Chat
You, 5 min ago
Hi! Anyone here? I want to know how I can buy Air UI?
You
Mary, 14 sec ago
Please call us + 100 295 000
Mary Stanform
Mary is typing...

Status Trialing

INV-00125

This month $251.12

Last month $12,256.12

Github Discuss
Watch 6,870
Star 16,356
Fork 569
[Feature Request] How to enable custom font that comes from svg #2460
Openzxs2162 wrote this issue 12 days ago · 0 comments
New Issue
Mary Stanform
zxs2162 wrote this issue 12 days ago · 0 comments

Description

Added child elements to the active text editor lose their scrollTop property when they are scrolled out of view.

Hydrogen a popular atom package adds a React Component inline to the text editor to view results from external code execution through jupyter kernels.

This React Component contains a standard div element (not an immediate child but down the sub tree) that if their is enough output can scroll.

If you scroll inside of the element and then scroll down the text editor for it to fall out of view and be temporarily removed from the DOM. If you scroll back up that scroll position inside the element is lost.

Steps to Reproduce

  1. Have hydrogen active and setup properly
  2. Use Run Cell command from hydrogen on the code below with about 50 extra new lines
for i in range(1000): print(i)
  1. Scroll down the editor
  2. Scroll back up the editor

Expected behavior: Everything to look the same

Actual behavior: Scroll top of the result view has been set to 0 upon removal and adding back to the active DOM

Reproduces how often: 100% of the time

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Atom : 1.37.0
Electron: 2.0.18
Chrome : 61.0.3163.100
Node : 8.9.3

Additional Information

This isnt platform specific either, and I don't believe its a hydrogen problem.
I believe this is a problem with how etch processes the render of React Components or how it stores html nodes when removing them. But I understand its more complex than that.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Notifications
Subscribe
You’re not receiving notifications from this thread.
4 participants
Mary Stanform
Mary Stanform
Mary Stanform
Mary Stanform